Skip to content

Conversation

@ByeongsuPark
Copy link
Contributor

@ByeongsuPark ByeongsuPark commented Mar 11, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

This PR adds RTL support to RemoveJitsiWidgetView as the original code did not seem to consider RTL.
In RTL, translationX can be a negative value since it slides from right to left.
Therefore I updated translationXcalculation logic so that it can accept negative value in RTL.
Additionally, I modified the activation threshold check logic to use the absolute value of translationX since it can be negative in RTL.

Motivation and context

Fix #8210

Screenshots / GIFs

Before

222949552-da8bcdb4-8ca5-4ca2-871d-9d1d9d8b3731.1.mp4

After

RTL

Screen_Recording_20230311_163816_Element.dbg.mp4

LTR

Screen_Recording_20230321_193157_Element.dbg.mp4

Tests

  • Step 1. Set the device environment to the RTL
  • Step 2. Launch the element App and enter the room
  • Step 3. Start a room call and come back to the room chat
  • Step 4. Use a removeJitsiWidgetView to slide to end a call.

Tested devices

  • Physical
  • Emulator
  • OS version(s): Android 13

Checklist

Signed-off-by: Byeongsu Park <byeongsu@soongsil.ac.kr>
@ByeongsuPark ByeongsuPark force-pushed the feature/bspark/bugfix-8210-removejitsiwidgetview-rtl-support branch from 5ef942a to 5779860 Compare March 11, 2023 08:59
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label Mar 21, 2023
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

@ByeongsuPark do you confirm that it's still working as expected on LTR mode?

@bmarty bmarty merged commit b85a064 into element-hq:develop Mar 21, 2023
@ByeongsuPark
Copy link
Contributor Author

Yes, I just added the demonstration video in LTR to Screenshot/Gif section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to end a room video call by Slide to end a call in RTL

2 participants